kou commented on PR #47815: URL: https://github.com/apache/arrow/pull/47815#issuecomment-3517007334
> Supported type codes range from 0 to 127 (128 different codes): https://github.com/apache/arrow/blob/main/cpp/src/arrow/type.cc#L1246 This check is for each type code value check. It's not a check for the number of type codes. @bkietz You added the following checks in #4781: https://github.com/apache/arrow/pull/4781/files#diff-a7012482623c4234c4fade3342b1180de1885484825790d88c1d55b672c5fe79R78-R79 https://github.com/apache/arrow/pull/4781/files#diff-a7012482623c4234c4fade3342b1180de1885484825790d88c1d55b672c5fe79R110-R113 The former change limits the number of type codes to 127 but the latter change limits the number of type codes to 128. Do you have any opinion for this report? @pitrou You may have an opinion for this report because you introduced `UnionType::kMaxTypeId` in #5892. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
