AdamGS commented on code in PR #8822:
URL: https://github.com/apache/arrow-rs/pull/8822#discussion_r2514756039
##########
arrow-data/src/data.rs:
##########
@@ -1783,7 +1783,7 @@ impl DataTypeLayout {
},
],
can_contain_null_mask: true,
- variadic: true,
+ variadic: false,
Review Comment:
This is a bug, see [the
spec](https://arrow.apache.org/docs/format/Columnar.html#variadic-buffers),
list views aren't represented by a variable number of buffers.
##########
arrow-array/src/ffi.rs:
##########
@@ -140,8 +140,8 @@ pub unsafe fn export_array_into_raw(
Ok(())
}
-// returns the number of bits that buffer `i` (in the C data interface) is
expected to have.
-// This is set by the Arrow specification
+/// returns the number of bits that buffer `i` (in the C data interface) is
expected to have.
Review Comment:
Just nicer when working with IDEs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
