lidavidm commented on code in PR #3607:
URL: https://github.com/apache/arrow-adbc/pull/3607#discussion_r2516263471
##########
c/include/arrow-adbc/adbc.h:
##########
@@ -2034,6 +2456,78 @@ AdbcStatusCode AdbcStatementExecuteSchema(struct
AdbcStatement* statement,
struct ArrowSchema* schema,
struct AdbcError* error);
+/// \brief Retrieve the schema of the next result set from a
+/// multi-statement query passed to AdbcStatementExecuteSchema.
+///
+/// This invalidates any prior result sets.
+///
+/// Depending on the driver, this may require first executing
+/// AdbcStatementPrepare.
+///
+/// \since ADBC API revision 1.2.0
+///
+/// \param[in] statement The statement to retrieve the next result set schema
from.
+/// \param[out] schema The result schema.
+/// \param[out] error An optional location to return an error
+/// message if necessary.
+///
+/// \return ADBC_STATUS_NOT_IMPLEMENTED if the driver does not support
+/// multi-result set execution, ADBC_STATUS_OK if next result set schema is
+/// being returned successfully. ADBC_STATUS_NOT_FOUND is returned
+/// when there are no more result sets.
Review Comment:
I don't like overloading the return code. I think it'd be more consistent to
return a schema with no release callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
