pitrou commented on code in PR #47992:
URL: https://github.com/apache/arrow/pull/47992#discussion_r2517381988
##########
cpp/src/arrow/util/rle_encoding_internal.h:
##########
@@ -659,32 +659,40 @@ auto RleBitPackedParser::PeekImpl(Handler&& handler) const
constexpr auto kMaxSize = bit_util::kMaxLEB128ByteLenFor<uint32_t>;
uint32_t run_len_type = 0;
- const auto header_bytes = bit_util::ParseLeadingLEB128(data_, kMaxSize,
&run_len_type);
-
- if (ARROW_PREDICT_FALSE(header_bytes == 0)) {
- // Malformed LEB128 data
- return {0, ControlFlow::Break};
- }
Review Comment:
That said, it might not hurt to keep the check either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
