adriangb commented on PR #8814: URL: https://github.com/apache/arrow-rs/pull/8814#issuecomment-3521848863
Or it might make it worse… it’s a trade off of indirection vs branch prediction. As we found out in https://github.com/apache/datafusion/pull/18449 the same change can be 70% faster on ARM MacBooks and 70% slower on x86. So needless to say this should not be merged without benchmarks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
