jonkeane commented on code in PR #48104:
URL: https://github.com/apache/arrow/pull/48104#discussion_r2518319294
##########
r/R/metadata.R:
##########
@@ -175,7 +175,7 @@ apply_arrow_r_metadata <- function(x, r_metadata) {
columns_metadata <- r_metadata$columns
if (is.data.frame(x)) {
# if columns metadata exists, apply it here
- if (length(names(x)) && !is.null(columns_metadata)) {
+ if (length(names(x)) && !is.null(columns_metadata) &&
!all(map_lgl(columns_metadata, is.null))) {
Review Comment:
I know we don't want to benchmark this in our code, but this looks like
something we want a test for, yeah?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
