etseidl commented on code in PR #8817:
URL: https://github.com/apache/arrow-rs/pull/8817#discussion_r2519037198
##########
parquet/src/file/metadata/writer.rs:
##########
@@ -113,6 +113,10 @@ impl<'a, W: Write> ThriftMetadataWriter<'a, W> {
for (row_group_idx, row_group) in
self.row_groups.iter_mut().enumerate() {
for (column_idx, column_metadata) in
row_group.columns.iter_mut().enumerate() {
if let Some(column_index) =
&column_indexes[row_group_idx][column_idx] {
+ // Missing indexes may also have the placeholder
ColumnIndexMetaData::NONE
+ if matches!(column_index, ColumnIndexMetaData::NONE) {
Review Comment:
I made this change in
https://github.com/apache/arrow-rs/pull/8817/commits/1654a1432a945996c312ab7f56b86a4f881a2833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
