westonpace commented on a change in pull request #10076:
URL: https://github.com/apache/arrow/pull/10076#discussion_r619477344
##########
File path: cpp/src/arrow/dataset/scanner_test.cc
##########
@@ -115,7 +116,7 @@ class TestScanner : public
DatasetFixtureMixinWithParam<TestScannerParams> {
AssertScanBatchesUnorderedEquals(expected.get(), scanner.get(), 1);
}
-};
+}; // namespace dataset
Review comment:
I am using whatever version of clang-format ships with VSCode and it has
format-on-save enabled. This happens when I am in the middle of modifying some
method and cutting/pasting code and end up (one way or another) with an extra
closing brace. E.g. I save with something like...
```
int foo() {
auto x = [] {}};
}
```
Then it seems that `clang-format` decides that final brace must be the
closing brace for the namespace and so it adds the comment. Later, when I fix
the error and resave, it does not remove the namespace comment.
I will investigate if a newer version of clang-format addresses this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
