alamb opened a new pull request, #8833: URL: https://github.com/apache/arrow-rs/pull/8833
WIP: I am verifying this PR is faster via benchmarks and if so I will polish is up and mark it ready for review # Which issue does this PR close? - part of https://github.com/apache/arrow-rs/issues/8806 # Rationale for this change - Following the changes in https://github.com/apache/arrow-rs/pull/8619, it appears that `apply_bitwise_binary_op` is faster and more general than `set_bits`, so let's deprecate set_bits in favor of it. This is part of a broader goal to consolidate the bitwise operations in DataFusion so that we can focus additional optimization energy on them (aka bithacks for the win) `set_bits` was introduced by @kazuyukitanimura in - #6288 # What changes are included in this PR? - [ ] Deprecate `set_bits` with a note to use apply_bitwise_binary_op instead. - [ ] Update any internal uses of set_bits to use apply_bitwise_binary_op instead. - [x] Update `set_bits` to use `apply_bitwise_binary_op` internally # Are these changes tested? Covered by existing tests I will also performance test # Are there any user-facing changes? If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
