liamzwbao commented on code in PR #8803: URL: https://github.com/apache/arrow-rs/pull/8803#discussion_r2523870256
########## arrow-array/src/array/list_array.rs: ########## Review Comment: Hi @alamb, while taking a look at [`generic_list_builder`](https://github.com/apache/arrow-rs/blob/f8d957287e59b65f23718f0c2eb67f621d21ac43/arrow-array/src/builder/generic_list_builder.rs#L36-L86), I noticed that we shouldn't increment offset for `NULL` as the top level element. so the logic offsets should be `[[0, 3], [3, 3], [3, 3], [3, 4], [4, 6]]` and the values offsets should be `[0, 3, 3, 3, 4, 6]`, is that right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
