alamb commented on code in PR #8824:
URL: https://github.com/apache/arrow-rs/pull/8824#discussion_r2524222622
##########
parquet/src/file/statistics.rs:
##########
@@ -515,7 +515,7 @@ pub struct ValueStatistics<T> {
is_min_max_backwards_compatible: bool,
}
-impl<T: ParquetValueType> ValueStatistics<T> {
+impl<T> ValueStatistics<T> {
Review Comment:
My reading of
https://github.com/apache/arrow-rs/blob/02fa779a9cb122c5218293be3afb980832701683/parquet/src/data_type.rs#L692-L691
is that `ParquetValueType` also requires `AsBytes`
Thus any type that used to work for ValueStatistics must have implemented
`AsBytes` already and thus this is a backwards compatible change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
