raulcd commented on code in PR #48075:
URL: https://github.com/apache/arrow/pull/48075#discussion_r2527033448
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2994,920 +3005,146 @@ endmacro()
# Dependencies for Arrow Flight RPC
macro(build_absl)
- message(STATUS "Building Abseil-cpp from source")
- set(absl_FOUND TRUE)
- set(absl_VERSION ${ARROW_ABSL_BUILD_VERSION})
+ message(STATUS "Building Abseil from source using FetchContent")
+ set(ABSL_VENDORED TRUE)
set(ABSL_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/absl_ep-install")
set(ABSL_INCLUDE_DIR "${ABSL_PREFIX}/include")
- set(ABSL_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" -DABSL_RUN_TESTS=OFF
- "-DCMAKE_INSTALL_PREFIX=${ABSL_PREFIX}")
+
+ # Configure Abseil options before FetchContent
+ set(ABSL_PROPAGATE_CXX_STD ON)
+ # We have to enable abseil install to generate abslConfig.cmake
+ # so GRPC can find Abseil thorught ExternalProject_Add
+ set(ABSL_ENABLE_INSTALL ON)
Review Comment:
that saves me some time :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
