alamb commented on code in PR #8851:
URL: https://github.com/apache/arrow-rs/pull/8851#discussion_r2529863718
##########
arrow-schema/src/schema.rs:
##########
@@ -95,20 +95,55 @@ impl SchemaBuilder {
/// Appends a [`FieldRef`] to this [`SchemaBuilder`] checking for collision
///
/// If an existing field exists with the same name, calls
[`Field::try_merge`]
- pub fn try_merge(&mut self, field: &FieldRef) -> Result<(), ArrowError> {
+ ///
+ /// If `preserve_nullability` is true, the nullability of the field will
be preserved,
+ /// i.e. merging a nullable field into a non-nullable field will result in
a nullable field.
+ /// If `preserve_nullability` is false, the nullability of the field will
be set to true.
+ pub fn try_merge(
+ &mut self,
+ field: &FieldRef,
+ preserve_nullability: bool,
Review Comment:
This would be a breaking API change, which means we would have to wait for
the next major release to get it in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
