kou commented on code in PR #48092:
URL: https://github.com/apache/arrow/pull/48092#discussion_r2535946206
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2985,10 +3019,8 @@ macro(build_cares)
"${LIBRESOLV_LIBRARY}")
endif()
- set(CARES_VENDORED TRUE)
-
- list(APPEND ARROW_BUNDLED_STATIC_LIBS c-ares::cares)
Review Comment:
Could you keep this? This is needed to build
`libarrow_bundled_dependencies.a`.
Note that we need to define this in the parent scope something like:
https://github.com/apache/arrow/blob/dbbe0ee148f6859d41e77035df842cf5b1f6843c/cpp/cmake_modules/ThirdpartyToolchain.cmake#L1840-L1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
