etseidl commented on code in PR #8797:
URL: https://github.com/apache/arrow-rs/pull/8797#discussion_r2538937608


##########
parquet/src/file/metadata/options.rs:
##########
@@ -29,6 +74,11 @@ use crate::schema::types::SchemaDescPtr;
 #[derive(Default, Debug, Clone)]
 pub struct ParquetMetaDataOptions {
     schema_descr: Option<SchemaDescPtr>,
+    encoding_stats_as_mask: bool,
+    // The outer option acts as a global boolean, so if 
`skip_encoding_stats.is_some()`
+    // is `true` then we're at least skipping some stats. The inner `Option` 
is a keep
+    // list of column indices to decode.
+    skip_encoding_stats: Option<Option<Arc<HashSet<usize>>>>,

Review Comment:
   You know, I thought about this when I was wiring it up, and rejected it for 
some reason. I can't remember why, and suspect it's because there's no reason 
not to. Done in 
https://github.com/apache/arrow-rs/pull/8797/commits/4aed15b0d677a1679ef1810492a13c9252df96b2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to