joe-ucp commented on PR #8869: URL: https://github.com/apache/arrow-rs/pull/8869#issuecomment-3549772264
@alamb Thanks so much for the detailed feedback and for pointing me at #8806 and #8854, I really appreciate it. You’re absolutely right that this PR ended up too large and tries to do too many things at once. I’m still very new to contributing on GitHub and to this project, so this was me exploring the space a bit too aggressively 😅 I’m happy to rework this into more focused PRs: First, I’ll open a small PR that just adds BooleanArray::binary / BooleanArray::unary wired up to the new buffer bitwise APIs (based on #8854 / the existing helpers). Separately, I’ll split out the nullif / layout-contract improvement into their own PR to make that review more manageable. I’ll start on the BooleanArray PR tomorrow and follow up with the nullif one after that. Once those are up, I’m also happy to keep iterating on the rest of the work described in #8806 in smaller reviewable chunks. Thanks again for taking the time to review and for the guidance! 🫡 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
