houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r619864093
##########
File path: datafusion/src/execution/dataframe_impl.rs
##########
@@ -252,7 +252,12 @@ mod tests {
let right = test_table()?.select_columns(&["c1", "c3"])?;
let left_rows = left.collect().await?;
let right_rows = right.collect().await?;
- let join = left.join(right, JoinType::Inner, &["c1"], &["c1"])?;
+ let join = left.join(
+ right,
+ JoinType::Inner,
+ vec![Column::from_name("c1".to_string())],
Review comment:
That's a great idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
