hiroyuki-sato opened a new pull request, #48175:
URL: https://github.com/apache/arrow/pull/48175
### Rationale for this change
This is the sub issue #44748.
* SC2048: Use "$@" (with quotes) to prevent whitespace problems.
* SC2181: Check exit code directly with e.g. if mycmd;, not indirectly with
$?.
```
In ci/scripts/util_download_apache.sh line 47:
for mirror in ${APACHE_MIRRORS[*]}
^------------------^ SC2048 (warning): Use "${array[@]}" (with
quotes) to prevent whitespace problems.
In ci/scripts/util_download_apache.sh line 50:
if [ $? == 0 ]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;',
not indirectly with $?.
For more information:
https://www.shellcheck.net/wiki/SC2048 -- Use "${array[@]}" (with quotes)
t...
https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with
e.g...
```
### What changes are included in this PR?
* SC2048: Use `"${APACHE_MIRRORS[@]}"` instead of `${APACHE_MIRRORS[*]}`.
* Sc2181: Use `if cmd ; then` statement instead of `$?`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
