alamb commented on code in PR #8882:
URL: https://github.com/apache/arrow-rs/pull/8882#discussion_r2543533059
##########
arrow-schema/src/datatype_parse.rs:
##########
@@ -173,14 +173,35 @@ impl<'a> Parser<'a> {
}
/// Parses the FixedSizeList type (called after `FixedSizeList` has been
consumed)
- /// E.g: FixedSizeList(5 x nullable Int64, field: 'foo')
+ ///
+ /// Examples:
+ /// * `FixedSizeList(5 x nullable Int64, field: 'foo')`
+ /// * `FixedSizeList(4, Int64)`
Review Comment:
Yes -- it is already (implicitly) covered by the round trip tests, but I
think you are right that an explicit test would be best
##########
arrow-schema/src/datatype_parse.rs:
##########
@@ -173,14 +173,35 @@ impl<'a> Parser<'a> {
}
/// Parses the FixedSizeList type (called after `FixedSizeList` has been
consumed)
- /// E.g: FixedSizeList(5 x nullable Int64, field: 'foo')
+ ///
+ /// Examples:
+ /// * `FixedSizeList(5 x nullable Int64, field: 'foo')`
+ /// * `FixedSizeList(4, Int64)`
Review Comment:
Yes -- it is already (implicitly) covered by the round trip tests, but I
think you are right that an additional explicit test would be best
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
