pitrou commented on code in PR #47993:
URL: https://github.com/apache/arrow/pull/47993#discussion_r2546147726
##########
ci/docker/python-wheel-windows-vs2022.dockerfile:
##########
@@ -29,7 +29,15 @@ RUN (if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11" &&
setx PYTHON_CMD "py
(if "%python%"=="3.13" setx PYTHON_VERSION "3.13.7" && setx PYTHON_CMD "py
-3.13") & \
(if "%python%"=="3.14" setx PYTHON_VERSION "3.14.0" && setx PYTHON_CMD "py
-3.14")
-RUN choco install -r -y --pre --no-progress python --version=%PYTHON_VERSION%
+# Use python_abi_tag env var to select regular or free-threaded Python
+ARG freethreaded=0
+ENV PYTHON_MODE=${freethreaded}
+RUN if "%PYTHON_MODE%"=="1" ( \
+ pymanager install --version %PYTHON_VERSION% --variant freethreaded \
+ ) else ( \
+ pymanager install --version %PYTHON_VERSION% \
+ )
Review Comment:
I think this can be simpler?
```suggestion
ARG python_variant=default
ENV PYTHON_VARIANT=${python_variant}
RUN pymanager install --version %PYTHON_VERSION% --variant %PYTHON_VARIANT%
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
