XiangpengHao commented on PR #8887: URL: https://github.com/apache/arrow-rs/pull/8887#issuecomment-3561393466
> This test here wants to cover the behavior of CastOptions; I think 1) we can't guarantee that the input is valid in `variant_get` here; 2) we'll do a type cast in `variant_get`(type_conversion.rs), and the cast may or may not succeed, and the `CastOptions::safe` controls how to handle suce cases. > > Returning to this test, we might be able to modify the input for `variant_get` here, but we may still need to ensure that different CastOptions are covered. Makes sense to me, thank you @klion26 , in that case I'll try to make the optimization only enabled for not safe cast case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
