kou commented on code in PR #48217:
URL: https://github.com/apache/arrow/pull/48217#discussion_r2553149466
##########
cpp/src/arrow/util/byte_stream_split_internal.h:
##########
@@ -330,15 +330,20 @@ inline void DoSplitStreams(const uint8_t* src, int width,
int64_t nvalues,
while (nvalues >= kBlockSize) {
for (int stream = 0; stream < width; ++stream) {
uint8_t* dest = dest_streams[stream];
+#if !ARROW_LITTLE_ENDIAN
+ const int src_stream = width - 1 - stream;
+#else
+ const int src_stream = stream;
+#endif
Review Comment:
Could you use
```cpp
#if ARROW_LITTLE_ENDIAN
little endian code
#else
big endian code
#endif
```
instead of
```cpp
#if !ARROW_LITTLE_ENDIAN
big endian code
#else
little endian code
#endif
```
for readability. In general, less `!` is easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
