k8ika0s commented on PR #48180:
URL: https://github.com/apache/arrow/pull/48180#issuecomment-3568429612
Mostly looks good to me — just one thought after reading through the recent
back-and-forth...
Given the updated handling of tail bytes and the SafeLoadUpTo8Bytes
discussion, I think this PR’s direction still makes sense. I’d just
double-check that the tail==8 path really can’t happen with the current unroll
logic, since @kou kou raised that question.
Otherwise the fixes seem aligned with the latest comments.
Willing to help test once the approach is finalized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
