pitrou commented on code in PR #48203:
URL: https://github.com/apache/arrow/pull/48203#discussion_r2556394347
##########
cpp/src/parquet/decoder.cc:
##########
@@ -1616,9 +1647,17 @@ class DeltaBitPackDecoder : public
TypedDecoderImpl<DType> {
for (int j = 0; j < values_decode; ++j) {
// Addition between min_delta, packed int and last_value should be
treated as
// unsigned addition. Overflow is as expected.
+#if ARROW_LITTLE_ENDIAN
buffer[i + j] = static_cast<UT>(min_delta_) + static_cast<UT>(buffer[i
+ j]) +
static_cast<UT>(last_value_);
last_value_ = buffer[i + j];
+#else
Review Comment:
Why this change? The added code for BE doesn't seem to do anything different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
