zeroshade commented on code in PR #578:
URL: https://github.com/apache/arrow-go/pull/578#discussion_r2558104886
##########
arrow/ipc/message.go:
##########
@@ -85,7 +84,9 @@ func NewMessage(meta, body *memory.Buffer) *Message {
meta: meta,
body: body,
}
- m.refCount.Add(1)
+ m.ReferenceBuffer(&m.meta, &m.body)
+ m.ReferenceDerived(unsafe.Pointer(&m.msg))
Review Comment:
we shouldn't need to track the `m.msg`, the point of the refcounting is to
track allocations made by the `memory.Allocator`, the flatbuffer message object
is never allocated by the memory.Allocator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
