pitrou commented on code in PR #48252:
URL: https://github.com/apache/arrow/pull/48252#discussion_r2560284867
##########
cpp/src/arrow/testing/random.cc:
##########
@@ -65,7 +65,7 @@ template <typename ValueType, typename DistributionType>
struct GeneratorFactory {
GeneratorFactory(ValueType min, ValueType max) : min_(min), max_(max) {}
- auto operator()(pcg32_fast* rng) const {
+ auto operator()(pcg32* rng) const {
Review Comment:
It turns out `pcg32_fast` is not high quality. When used with
`RandomArrayGenerator::Strings`, the first string character would very often be
`A`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
