felipecrv commented on code in PR #3714: URL: https://github.com/apache/arrow-adbc/pull/3714#discussion_r2566826487
########## rust/core/src/sync.rs: ########## @@ -0,0 +1,793 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: async being the default for database APIs is a bad idea IMO. Database connections are stateful objects that accumulates statements in transactions. Async may re-order actual execution of the queries on the connection. A world of pain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
