luoyuxia commented on PR #904:
URL: https://github.com/apache/arrow-java/pull/904#issuecomment-3583889604

   > Hello @luoyuxia
   > 
   > I found couple of problem, dictionary encoding access is not given from 
JAVA to C++ JNI call, implementation of it is pending in both side. Also giving 
wrong name for compression is assumed as uncompressed this should not be the 
case, as if there is a typeo it should not allow execution. As current 
arrow-java version 18 does not allow us to give any name for compression except 
snappy, gzip, zstd, lz4, brotli and uncompressed.
   
   Thanks for your feedback. 
   
   > dictionary encoding access is not given from JAVA to C++ JNI call, 
implementation of it is pending in both side
   
   Do you mean arrow-cpp doesn't support dictionary encoding access?
   
   > Also giving wrong name for compression is assumed as uncompressed this 
should not be the case, as if there is a typeo it should not allow execution.
   Yes, I think we can improve it in this pr
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to