hiroyuki-sato commented on code in PR #48285:
URL: https://github.com/apache/arrow/pull/48285#discussion_r2571558685
##########
cpp/src/parquet/arrow/reader.h:
##########
@@ -126,6 +126,14 @@ class PARQUET_EXPORT FileReader {
std::unique_ptr<ParquetFileReader> reader,
std::unique_ptr<FileReader>* out);
+ /// Factory function to create a FileReader from a ParquetFileReader and
properties
+ static ::arrow::Result<std::unique_ptr<FileReader>> Make(
+ ::arrow::MemoryPool* pool, std::unique_ptr<ParquetFileReader> reader,
+ const ArrowReaderProperties& properties);
Review Comment:
`23.0.0` or `24.0.0` in this case?
```diff
/Users/hsato/OpenProjects/arrow/arrow/cpp/src/parquet/arrow/reader.h:120:3:
note: 'Make' has been explicitly marked deprecated hediff --git
a/cpp/src/parquet/arrow/reader.h b/cpp/src/parquet/arrow/reader.h
index 3bdd7f18ca..996cda1aaf 100644
--- a/cpp/src/parquet/arrow/reader.h
+++ b/cpp/src/parquet/arrow/reader.h
@@ -116,12 +116,16 @@ class RowGroupReader;
class PARQUET_EXPORT FileReader {
public:
/// Factory function to create a FileReader from a ParquetFileReader and
properties
+ /// \deprecated Deprecated in 23.0.0. Use arrow::Result version instead.
+ ARROW_DEPRECATED("Deprecated in 23.0.0. Use arrow::Result version
instead.")
static ::arrow::Status Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
const ArrowReaderProperties& properties,
std::unique_ptr<FileReader>* out);
/// Factory function to create a FileReader from a ParquetFileReader
+ /// \deprecated Deprecated in 23.0.0. Use arrow::Result version instead.
+ ARROW_DEPRECATED("Deprecated in 23.0.0. Use arrow::Result version
instead.")
static ::arrow::Status Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
std::unique_ptr<FileReader>* out);
```
When I add deprecated, an error occurs in this area. Should I fix this? (Or
add `ARROW_DEPRECATED` in another PR?)
```
/path/toarrow/arrow/cpp/src/parquet/arrow/reader.cc:1407:22: error: 'Make'
is deprecated: Deprecated in 23.0.0. Use arrow::Result version instead.
[-Werror,-Wdeprecated-declarations]
1407 | return FileReader::Make(pool_, std::move(raw_reader_),
properties_, out);
| ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
