Vishwanatha-HD commented on code in PR #48205:
URL: https://github.com/apache/arrow/pull/48205#discussion_r2571991742
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2578,13 +2579,31 @@ struct SerializeFunctor<
if constexpr (std::is_same_v<ArrowType, ::arrow::Decimal64Type>) {
*p++ = ::arrow::bit_util::ToBigEndian(u64_in[0]);
} else if constexpr (std::is_same_v<ArrowType, ::arrow::Decimal128Type>)
{
+#if ARROW_LITTLE_ENDIAN
Review Comment:
@pitrou.. I have rebased this to git main and removed the below piece of
code..
```
-#if ARROW_LITTLE_ENDIAN
- if (num_bytes < 0 || num_bytes > data_size - 4) {
-#else
if (num_bytes < 0 || num_bytes > data_size) {
----------->>>>> Only retaining this line now..
-#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
