andygrove commented on a change in pull request #69: URL: https://github.com/apache/arrow-datafusion/pull/69#discussion_r619840306
########## File path: python/Cargo.toml ########## @@ -0,0 +1,39 @@ +[package] +name = "datafusion" +version = "0.2.1" +authors = ["Jorge C. Leitao <jorgecarlei...@gmail.com>"] Review comment: ```suggestion authors = ["Apache Arrow <d...@arrow.apache.org>"] ``` ########## File path: python/LICENSE ########## @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2020 Jorge Leitao Review comment: This presumably needs to change to an ASF copyright? ########## File path: python/LICENSE ########## @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2020 Jorge Leitao Review comment: Also, I assume we need to licence under ASL 2.0 as well ########## File path: python/LICENSE ########## @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2020 Jorge Leitao Review comment: Also, I assume we need to license under ASL 2.0 as well ########## File path: python/LICENSE ########## @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2020 Jorge Leitao Review comment: I'm unsure whether we can use an MIT license in an ASF project or not and wasn't able to find answers right away on the ASF site but we can ask for advice on this from the incubator folks. What is the reason for the MIT license here? Is this something that is expected in the Python ecosystem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org