raulcd commented on code in PR #48250:
URL: https://github.com/apache/arrow/pull/48250#discussion_r2576750673
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2852,52 +2852,24 @@ function(build_re2)
set(RE2_VENDORED
TRUE
PARENT_SCOPE)
- set(RE2_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/re2_fc-install")
- set(RE2_PREFIX
- "${RE2_PREFIX}"
- PARENT_SCOPE)
fetchcontent_declare(re2
URL ${RE2_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_RE2_BUILD_SHA256_CHECKSUM}")
+ URL_HASH "SHA256=${ARROW_RE2_BUILD_SHA256_CHECKSUM}"
+ EXCLUDE_FROM_ALL)
Review Comment:
yes, sorry, I didn't know about `FC_DECLARE_COMMON_OPTIONS`. I'll remove the
manual `EXCLUDE_FROM_ALL` and add `${FC_DECLARE_COMMON_OPTIONS}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
