etseidl commented on code in PR #8894:
URL: https://github.com/apache/arrow-rs/pull/8894#discussion_r2578248517
##########
parquet/src/arrow/decoder/mod.rs:
##########
@@ -21,4 +21,5 @@ mod delta_byte_array;
mod dictionary_index;
pub use delta_byte_array::DeltaByteArrayDecoder;
+#[allow(unused_imports)]
Review Comment:
This one needs to be removed as well.
##########
parquet/src/arrow/schema/extension.rs:
##########
@@ -26,8 +26,9 @@
use crate::basic::LogicalType;
use crate::errors::ParquetError;
use crate::schema::types::Type;
-use arrow_schema::Field;
+#[cfg(feature = "variant_experimental")]
Review Comment:
The changes to this file should be reverted.
##########
parquet/src/file/metadata/writer.rs:
##########
@@ -477,43 +452,9 @@ impl<'a, W: Write> ParquetMetaDataWriter<'a, W> {
Ok(())
}
-
- fn convert_column_indexes(&self) ->
Option<Vec<Vec<Option<ColumnIndexMetaData>>>> {
- // TODO(ets): we're converting from ParquetColumnIndex to
vec<vec<option>>,
- // but then converting back to ParquetColumnIndex in the end. need to
unify this.
- self.metadata
- .column_index()
- .map(|row_group_column_indexes| {
- (0..self.metadata.row_groups().len())
- .map(|rg_idx| {
- let column_indexes = &row_group_column_indexes[rg_idx];
- column_indexes
- .iter()
- .map(|column_index| Some(column_index.clone()))
- .collect()
- })
- .collect()
- })
- }
-
- fn convert_offset_index(&self) ->
Option<Vec<Vec<Option<OffsetIndexMetaData>>>> {
- self.metadata
- .offset_index()
- .map(|row_group_offset_indexes| {
- (0..self.metadata.row_groups().len())
- .map(|rg_idx| {
- let offset_indexes = &row_group_offset_indexes[rg_idx];
- offset_indexes
- .iter()
- .map(|offset_index| Some(offset_index.clone()))
- .collect()
- })
- .collect()
- })
- }
}
-#[derive(Debug, Default)]
Review Comment:
Please revert this change
##########
CHANGELOG.md:
##########
@@ -19,6 +19,23 @@
# Changelog
+## [58.0.0](https://github.com/apache/arrow-rs/tree/58.0.0) (2025-11-28)
Review Comment:
Please remove this
##########
.gitignore:
##########
@@ -103,3 +103,4 @@ __pycache__/
# Parquet file from arrow_reader_clickbench
hits_1.parquet
+/.cursor
Review Comment:
Please remove
##########
parquet/src/bin/parquet-fromcsv-help.txt:
##########
@@ -1,4 +1,3 @@
-
Review Comment:
Please revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
