raulcd commented on code in PR #48250:
URL: https://github.com/apache/arrow/pull/48250#discussion_r2578854723
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3265,289 +3192,125 @@ macro(build_grpc)
PC_PACKAGE_NAMES
libcares)
- message(STATUS "Building gRPC from source")
+ list(APPEND CMAKE_MESSAGE_INDENT "gRPC: ")
+ message(STATUS "Building gRPC from source using FetchContent")
+ set(GRPC_VENDORED
+ TRUE
+ PARENT_SCOPE)
- set(GRPC_BUILD_DIR
"${CMAKE_CURRENT_BINARY_DIR}/grpc_ep-prefix/src/grpc_ep-build")
- set(GRPC_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/grpc_ep-install")
- set(GRPC_HOME "${GRPC_PREFIX}")
- set(GRPC_INCLUDE_DIR "${GRPC_PREFIX}/include")
+ fetchcontent_declare(grpc
+ URL ${GRPC_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_GRPC_BUILD_SHA256_CHECKSUM}")
- set(GRPC_STATIC_LIBRARY_GPR
-
"${GRPC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}gpr${CMAKE_STATIC_LIBRARY_SUFFIX}"
- )
- set(GRPC_STATIC_LIBRARY_GRPC
-
"${GRPC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}grpc${CMAKE_STATIC_LIBRARY_SUFFIX}"
- )
- set(GRPC_STATIC_LIBRARY_GRPCPP
-
"${GRPC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}grpc++${CMAKE_STATIC_LIBRARY_SUFFIX}"
- )
- set(GRPC_STATIC_LIBRARY_ADDRESS_SORTING
-
"${GRPC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}address_sorting${CMAKE_STATIC_LIBRARY_SUFFIX}"
- )
- set(GRPC_STATIC_LIBRARY_GRPCPP_REFLECTION
-
"${GRPC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}grpc++_reflection${CMAKE_STATIC_LIBRARY_SUFFIX}"
- )
- set(GRPC_STATIC_LIBRARY_UPB
-
"${GRPC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}upb${CMAKE_STATIC_LIBRARY_SUFFIX}"
- )
- set(GRPC_CPP_PLUGIN
"${GRPC_PREFIX}/bin/grpc_cpp_plugin${CMAKE_EXECUTABLE_SUFFIX}")
+ prepare_fetchcontent()
- set(GRPC_CMAKE_PREFIX)
+ if(PROTOBUF_VENDORED)
+ set(_gRPC_PROTOBUF_LIBRARIES
+ "protobuf::libprotobuf"
+ CACHE STRING "" FORCE)
Review Comment:
@kou the only one that seems necessary is the one here:
https://github.com/apache/arrow/pull/48250/commits/00a838f3b338c986e19d0376847eb72210643c4d
see the current CI failures, I can revert that one.
The rest doesn't seem necessary even though I have to investigate why
`gRPC_SSL_PROVIDER` fails locally for me if I don't put CACHE (all CI is
successful so might be that I miss to install something locally).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
