etseidl commented on code in PR #8305:
URL: https://github.com/apache/arrow-rs/pull/8305#discussion_r2585950071
##########
parquet/src/file/metadata/thrift/mod.rs:
##########
@@ -1236,13 +1210,16 @@ pub(super) fn serialize_column_meta_data<W: Write>(
if let Some(dictionary_page_offset) = column_chunk.dictionary_page_offset {
last_field_id = dictionary_page_offset.write_thrift_field(w, 11,
last_field_id)?;
}
- // PageStatistics is the same as thrift Statistics, but writable
- let stats = page_stats_to_thrift(column_chunk.statistics());
- if let Some(stats) = stats {
- last_field_id = stats.write_thrift_field(w, 12, last_field_id)?;
- }
- if let Some(page_encoding_stats) = column_chunk.page_encoding_stats() {
- last_field_id = page_encoding_stats.write_thrift_field(w, 13,
last_field_id)?;
+
+ if should_write_column_stats(column_chunk) {
Review Comment:
Is the idea here to only write the required bits of the column meta_data so
readers won't complain? If so, then should all of the fields below also be
skipped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
