alamb commented on code in PR #8822:
URL: https://github.com/apache/arrow-rs/pull/8822#discussion_r2586144065
##########
arrow-pyarrow-integration-testing/tests/test_sql.py:
##########
@@ -112,8 +114,16 @@ def assert_pyarrow_leak():
),
]
-_unsupported_pyarrow_types = [
-]
+if PYARROW_MAJOR_VER >= 16:
Review Comment:
Can you file a follow on ticket / PR to discuss dropping support for
versions less than 16?
##########
arrow-schema/src/ffi.rs:
##########
@@ -456,6 +456,14 @@ impl TryFrom<&FFI_ArrowSchema> for DataType {
let c_child = c_schema.child(0);
DataType::LargeList(Arc::new(Field::try_from(c_child)?))
}
+ "+vl" => {
Review Comment:
Double checked that this matches
https://arrow.apache.org/docs/format/CDataInterface.html#data-type-description-format-strings
✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
