lidavidm commented on code in PR #48323:
URL: https://github.com/apache/arrow/pull/48323#discussion_r2587040144
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_stream_chunk_buffer.cc:
##########
@@ -68,11 +68,13 @@ FlightStreamChunkBuffer::FlightStreamChunkBuffer(
// call. temp_flight_sql_client is intentionally null if the list of
endpoint
// Locations is empty.
// After all data is fetched from reader, the temp client is closed.
-
- // gh-48084 Replace boost::optional with std::optional
- return boost::make_optional(
- is_not_ok || is_not_empty,
- std::make_pair(std::move(result), temp_flight_sql_client));
+ if (is_not_ok || is_not_empty) {
+ return std::make_optional(
+ std::make_pair(std::move(result), temp_flight_sql_client));
+ } else {
+ return std::optional<std::pair<arrow::Result<FlightStreamChunk>,
+ std::shared_ptr<FlightSqlClient>>>{};
Review Comment:
nit: does nullopt not work here?
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/types.h:
##########
@@ -172,7 +172,7 @@ enum RowStatus : uint16_t {
};
struct MetadataSettings {
- boost::optional<int32_t> string_column_length{boost::none};
+ std::optional<int32_t> string_column_length{std::nullopt};
Review Comment:
The default initialization is nullopt so there's no need to write it out
explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
