kou commented on code in PR #48318:
URL: https://github.com/apache/arrow/pull/48318#discussion_r2587060311
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3391,42 +3391,79 @@ endif()
# ----------------------------------------------------------------------
# GCS and dependencies
-macro(build_crc32c_once)
- if(NOT TARGET crc32c_ep)
- message(STATUS "Building crc32c from source")
- # Build crc32c
- set(CRC32C_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/crc32c_ep-install")
- set(CRC32C_INCLUDE_DIR "${CRC32C_PREFIX}/include")
- set(CRC32C_CMAKE_ARGS
- ${EP_COMMON_CMAKE_ARGS}
- "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
- -DCRC32C_BUILD_TESTS=OFF
- -DCRC32C_BUILD_BENCHMARKS=OFF
- -DCRC32C_USE_GLOG=OFF)
+function(build_crc32c_once)
+ list(APPEND CMAKE_MESSAGE_INDENT "crc32c: ")
Review Comment:
```suggestion
list(APPEND CMAKE_MESSAGE_INDENT "CRC32C: ")
```
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3391,42 +3391,79 @@ endif()
# ----------------------------------------------------------------------
# GCS and dependencies
-macro(build_crc32c_once)
- if(NOT TARGET crc32c_ep)
- message(STATUS "Building crc32c from source")
- # Build crc32c
- set(CRC32C_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/crc32c_ep-install")
- set(CRC32C_INCLUDE_DIR "${CRC32C_PREFIX}/include")
- set(CRC32C_CMAKE_ARGS
- ${EP_COMMON_CMAKE_ARGS}
- "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
- -DCRC32C_BUILD_TESTS=OFF
- -DCRC32C_BUILD_BENCHMARKS=OFF
- -DCRC32C_USE_GLOG=OFF)
+function(build_crc32c_once)
+ list(APPEND CMAKE_MESSAGE_INDENT "crc32c: ")
+ message(STATUS "Building crc32c from source using FetchContent")
Review Comment:
```suggestion
message(STATUS "Building CRC32C from source using FetchContent")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
