friendlymatthew commented on code in PR #8891:
URL: https://github.com/apache/arrow-rs/pull/8891#discussion_r2588368001
##########
arrow-schema/src/fields.rs:
##########
@@ -339,19 +339,166 @@ impl UnionFields {
///
/// See <https://arrow.apache.org/docs/format/Columnar.html#union-layout>
///
+ /// # Errors
+ ///
+ /// This function returns an error if:
+ /// - Any type_id appears more than once (duplicate type ids)
+ /// - Any field appears more than once (duplicate fields)
Review Comment:
Hm, that makes sense to me. I suspect this will cause some subtleties in the
way we compare Union types, but I'll make sure to document that in a follow up
PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
