pitrou commented on code in PR #48336:
URL: https://github.com/apache/arrow/pull/48336#discussion_r2589567791
##########
cpp/src/parquet/bloom_filter_reader.cc:
##########
@@ -52,7 +52,7 @@ std::unique_ptr<BloomFilter>
RowGroupBloomFilterReaderImpl::GetColumnBloomFilter
auto col_chunk = row_group_metadata_->ColumnChunk(i);
std::unique_ptr<ColumnCryptoMetaData> crypto_metadata =
col_chunk->crypto_metadata();
if (crypto_metadata != nullptr) {
- ParquetException::NYI("Cannot read encrypted bloom filter yet");
+ ParquetException::NYI("BloomFilter decryption is not yet supported");
Review Comment:
This just ensures the same exception message in used in different places.
##########
cpp/src/parquet/encryption/encryption.h:
##########
@@ -95,13 +95,6 @@ class PARQUET_EXPORT KeyAccessDeniedException : public
ParquetException {
: ParquetException(columnPath.c_str()) {}
};
-inline const uint8_t* str2bytes(const std::string& str) {
Review Comment:
This was unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
