Vishwanatha-HD commented on code in PR #48166:
URL: https://github.com/apache/arrow/pull/48166#discussion_r2589856710
##########
cpp/src/arrow/ipc/message_internal_test.cc:
##########
@@ -74,6 +76,29 @@ TEST(TestMessageInternal, TestByteIdentical) {
0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x66, 0x30, 0x00, 0x00,
0x08, 0x00,
0x0C, 0x00, 0x08, 0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x01,
0x40, 0x00, 0x00, 0x00};
+#else
+ // On Big-endian systems, FlatBuffer serialization can produce slightly
different
+ // output across different platforms and toolchains.
Review Comment:
Yes.. sure.. This is the code that I have right now.. (As Code formatting
is not quite correct.. please dont mind)..
```
TEST(TestMessageInternal, TestByteIdentical) {
DictionaryFieldMapper mapper;
for (const auto endianness : {Endianness::Little, Endianness::Big}) {
// Create a simple Schema with just two metadata KVPs
auto f0 = field("f0", int64());
auto f1 = field("f1", int64());
std::vector<std::shared_ptr<Field>> fields = {f0, f1};
std::shared_ptr<KeyValueMetadata> metadata =
KeyValueMetadata::Make({"key_1", "key_2"}, {"key_1_value",
"key_2_value"});
auto schema = ::arrow::schema({f0}, endianness, metadata);
// Serialize the Schema to a Buffer
std::shared_ptr<Buffer> out_buffer;
ASSERT_OK(
WriteSchemaMessage(*schema, mapper, IpcWriteOptions::Defaults(),
&out_buffer));
// This is example output from macOS+ARM+LLVM
const uint8_t expected[] = {
0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x0A, 0x00, 0x0E, 0x00, 0x06,
0x00, 0x05, 0x00,
0x08, 0x00, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x04, 0x00, 0x10,
0x00, 0x00, 0x00,
0x00, 0x00, 0x0A, 0x00, 0x0C, 0x00, 0x00, 0x00, 0x04, 0x00, 0x08,
0x00, 0x0A, 0x00,
0x00, 0x00, 0x6C, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, 0x02,
0x00, 0x00, 0x00,
0x38, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, 0xD8, 0xFF, 0xFF,
0xFF, 0x18, 0x00,
0x00, 0x00, 0x04, 0x00, 0x00, 0x00, 0x0B, 0x00, 0x00, 0x00, 0x6B,
0x65, 0x79, 0x5F,
0x32, 0x5F, 0x76, 0x61, 0x6C, 0x75, 0x65, 0x00, 0x05, 0x00, 0x00,
0x00, 0x6B, 0x65,
0x79, 0x5F, 0x32, 0x00, 0x00, 0x00, 0x08, 0x00, 0x0C, 0x00, 0x04,
0x00, 0x08, 0x00,
0x08, 0x00, 0x00, 0x00, 0x18, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00,
0x00, 0x0B, 0x00,
0x00, 0x00, 0x6B, 0x65, 0x79, 0x5F, 0x31, 0x5F, 0x76, 0x61, 0x6C,
0x75, 0x65, 0x00,
0x05, 0x00, 0x00, 0x00, 0x6B, 0x65, 0x79, 0x5F, 0x31, 0x00, 0x00,
0x00, 0x01, 0x00,
0x00, 0x00, 0x14, 0x00, 0x00, 0x00, 0x10, 0x00, 0x14, 0x00, 0x08,
0x00, 0x06, 0x00,
0x07, 0x00, 0x0C, 0x00, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00, 0x00,
0x00, 0x00, 0x00,
0x01, 0x02, 0x10, 0x00, 0x00, 0x00, 0x1C, 0x00, 0x00, 0x00, 0x04,
0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x66, 0x30, 0x00,
0x00, 0x08, 0x00,
0x0C, 0x00, 0x08, 0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x01,
0x40, 0x00, 0x00, 0x00};
Buffer expected_buffer(expected, sizeof(expected));
AssertBufferEqual(expected_buffer, *out_buffer);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
