Vishwanatha-HD commented on code in PR #48166:
URL: https://github.com/apache/arrow/pull/48166#discussion_r2590109030
##########
cpp/src/arrow/ipc/message_internal_test.cc:
##########
@@ -74,6 +76,29 @@ TEST(TestMessageInternal, TestByteIdentical) {
0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x66, 0x30, 0x00, 0x00,
0x08, 0x00,
0x0C, 0x00, 0x08, 0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x01,
0x40, 0x00, 0x00, 0x00};
+#else
+ // On Big-endian systems, FlatBuffer serialization can produce slightly
different
+ // output across different platforms and toolchains.
Review Comment:
@pitrou.. Yes.. you are right.. We need a two different expected output..
Because on s390x, the expected num bytes are 232, whereas on LE its 228 bytes..
But, I just tested with only Endianness::Little and it works fine..
(Basically, this test is not executing on BE machine, in such case)..
So, I hope I need to maintain two different output structures, as I have in
the patch, right?..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
