wgtmac commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r2593144411
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1867,6 +1876,7 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
chunk_geospatial_statistics_->Update(values, num_values);
}
}
+ bloom_filter_writer_->Update(values, num_values);
Review Comment:
Yes, bloom_filter_writer_ internally checks if this column has enabled bloom
filter and it is a no-op if not. If you prefer to move the internal check out
and check if bloom_filter_writer_ is nullptr here, I can make such change.
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1867,6 +1876,7 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
chunk_geospatial_statistics_->Update(values, num_values);
}
}
+ bloom_filter_writer_->Update(values, num_values);
Review Comment:
Yes, bloom_filter_writer_ internally checks if this column has enabled bloom
filter and it is a no-op if not. If you prefer to move the internal check out
and check if bloom_filter_writer_ is nullptr here, I can make such a change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
