Kinrany commented on code in PR #546:
URL:
https://github.com/apache/arrow-rs-object-store/pull/546#discussion_r2593795469
##########
src/path/mod.rs:
##########
@@ -348,13 +398,22 @@ where
I: Into<PathPart<'a>>,
{
fn from_iter<T: IntoIterator<Item = I>>(iter: T) -> Self {
- let raw = T::into_iter(iter)
- .map(|s| s.into())
- .filter(|s| !s.raw.is_empty())
- .map(|s| s.raw)
- .join(DELIMITER);
+ let mut this = Self::ROOT;
+ this.extend(iter);
+ this
+ }
+}
- Self { raw }
+impl<'a, I: Into<PathPart<'a>>> Extend<I> for Path {
+ fn extend<T: IntoIterator<Item = I>>(&mut self, iter: T) {
Review Comment:
Hmm, note that I haven't added any docs on `Path` directly. Since this is a
standard trait, I expect people to find it by looking at the list of
implemented traits 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
