tennisleng opened a new pull request, #48377: URL: https://github.com/apache/arrow/pull/48377
### Rationale for this change This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in `ASSERT_DOUBLE_EQ` and `ASSERT_FLOAT_EQ` macros. Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written). See: https://github.com/google/googletest/commit/59c924bc471cefea25a7cf7eb40b6c101b170b12 ### What changes are included in this PR? Updated `cpp/thirdparty/versions.txt`: - `ARROW_GTEST_BUILD_VERSION`: 1.16.0 → 1.17.0 - `ARROW_GTEST_BUILD_SHA256_CHECKSUM`: Updated to match new version ### Are these changes tested? This is a dependency version update. Existing tests will validate compatibility. ### Are there any user-facing changes? No.This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in ASSERT_DOUBLE_EQ and ASSERT_FLOAT_EQ macros. Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written). This was fixed in GoogleTest commit 59c924bc. See: https://github.com/google/googletest/commit/59c924bc471cefea25a7cf7eb40b6c101b170b12 Thanks for opening a pull request! If this is your first pull request you can find detailed information on how to contribute here: * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request) * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html) Please remove this line and the above text before creating your pull request. ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.) **This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
