WillAyd commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2596800779
##########
.github/workflows/python.yml:
##########
@@ -288,11 +288,39 @@ jobs:
env:
# We can invalidate the current cache by updating this.
CACHE_VERSION: "2025-09-16.1"
+ - name: Install conda
+ shell: cmd
+ run: |
+ curl -L
https://github.com/conda-forge/miniforge/releases/download/25.11.0-0/Miniforge3-25.11.0-0-Windows-x86_64.exe
-o miniforge.exe
+ start /wait "" .\miniforge.exe /S /D=C:\miniforge
+ del .\miniforge.exe
+ C:\miniforge\Scripts\conda.exe init cmd.exe
+ echo
C:\miniforge\Scripts;C:\miniforge\Library\bin;C:\miniforge\condabin>>
%GITHUB_PATH%
+ - name: Create conda environment
+ shell: cmd
+ run: |
+ conda env create -n pyarrow-dev -f .\ci\conda_env_cpp.txt -y
+ conda env update -n pyarrow-dev -f .\ci\conda_env_python.txt
- name: Build Arrow C++ and PyArrow
shell: cmd
+ env:
+ PYTHON_CMD: "python"
run: |
- call "ci\scripts\python_build.bat" %cd% "${{
steps.path-info.outputs.usr-windows-dir }}"
+ call activate pyarrow-dev || exit /B 1
+ call "ci\scripts\python_build.bat" %cd% "%CONDA_PREFIX%"
+ - name: Upload wheel
+ if: always() # ensures this runs even on failure
+ uses: actions/upload-artifact@v4
+ with:
+ name: built-wheel
+ path: python/dist/*.whl
- name: Test PyArrow
shell: cmd
+ env:
+ PYTHON_CMD: "python"
+ # TODO: Renaming lz4 library is a hack - see where the name gets mixed
up
run: |
+ call activate pyarrow-dev
+ move C:\miniforge\envs\pyarrow-dev\Library\bin\liblz4.dll
C:\miniforge\envs\pyarrow-dev\Library\bin\lz4.dll
Review Comment:
OK looks like a version issue. 1.9.4 uses the `lib` prefix:
https://conda-metadata-app.streamlit.app/?q=conda-forge%2Fwin-64%2Flz4-c-1.9.4-hcfcfb64_0.conda
but 1.10.0 seems to have dropped it:
https://conda-metadata-app.streamlit.app/?q=conda-forge%2Fwin-64%2Flz4-c-1.10.0-h2466b09_1.conda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
