mkleen commented on code in PR #8963:
URL: https://github.com/apache/arrow-rs/pull/8963#discussion_r2597819599
##########
arrow-select/src/zip.rs:
##########
@@ -284,7 +287,9 @@ impl ScalarZipper {
DataType::LargeBinary => {
Arc::new(BytesScalarImpl::<LargeBinaryType>::new(truthy,
falsy)) as Arc<dyn ZipImpl>
},
- // TODO: Handle Utf8View
https://github.com/apache/arrow-rs/issues/8724
+ DataType::Utf8View => {
+ Arc::new(ByteViewScalarImpl::<StringViewType>::new(truthy,
falsy)) as Arc<dyn ZipImpl>
Review Comment:
I am not sure how to work around this. `ByteViewScalarImpl` should not be
bound `StringViewType` by default. This should be dependent on the truthy/falsy
inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
