hiroyuki-sato commented on code in PR #48413:
URL: https://github.com/apache/arrow/pull/48413#discussion_r2602199546


##########
ruby/red-arrow-format/lib/arrow-format/file-reader.rb:
##########
@@ -159,6 +161,11 @@ def read_field(fb_field)
         when Org::Apache::Arrow::Flatbuf::Precision::DOUBLE
           type = Float64Type.singleton
         end
+      when Org::Apache::Arrow::Flatbuf::Date
+        case fb_type.unit
+        when Org::Apache::Arrow::Flatbuf::DateUnit::DAY
+          type = Date32Type.singleton
+        end

Review Comment:
   Just in case: 
[`DateUnit::MILLISECOND`](https://github.com/apache/arrow/blob/main/format/Schema.fbs#L243)
 will implement aonther PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to