ngoldbaum commented on code in PR #48391: URL: https://github.com/apache/arrow/pull/48391#discussion_r2603153573
########## python/pyarrow/src/arrow/python/numpy_to_arrow.cc: ########## @@ -59,6 +60,12 @@ #include "arrow/python/type_traits.h" #include "arrow/python/vendored/pythoncapi_compat.h" +#if NPY_ABI_VERSION >= 0x02000000 Review Comment: You could also just `#define NPY_VSTRING 2056` if it isn't defined in an old numpy version. Technically we could change that value in NumPy but I seriously doubt we would. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
