hiroyuki-sato commented on code in PR #48424:
URL: https://github.com/apache/arrow/pull/48424#discussion_r2606519767
##########
ruby/red-arrow-format/lib/arrow-format/file-reader.rb:
##########
@@ -166,6 +166,8 @@ def read_field(fb_field)
case fb_type.unit
when Org::Apache::Arrow::Flatbuf::DateUnit::DAY
type = Date32Type.singleton
+ when Org::Apache::Arrow::Flatbuf::DateUnit::MILLISECOND
+ type = Date64Type.singleton
Review Comment:
Do we need? (Cornor case)
```ruby
when Org::Apache::Arrow::Flatbuf::DateUnit::MILLISECOND
type = Date64Type.singleton
else
#raise Error
end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
